PunBB Resource

Your ultimate PunBB resource!

Keywords:

    (Extended)

You are not logged in.


Login to move these ads to the bottom of the page

#26 2005-07-30 18:55:07

aegreatone
New member
Registered: 2005-07-29
Posts: 2

Re: Private Messaging System 1.2.x 1.2.1

Connorhd wrote:

if you install the mod properly there is one, it should says Messages

do'h. Everything is working right except seeing "Messages" in my top menu. do you know where I messed up? what file?

Offline

 

#27 2005-07-30 20:15:14

Metsuo
Member
Registered: 2005-02-02
Posts: 154
Website

Re: Private Messaging System 1.2.x 1.2.1

I'm pretty sure you have 1.2.1 and up.

In admin options you can edit your links

x = <a href="message_list.php">Messages</a>


chown -R us ./base
Archtype-K

Offline

 

#28 2005-08-09 18:20:13

propheçy
Member
From: york, pa
Registered: 2005-04-29
Posts: 16
Website

Re: Private Messaging System 1.2.x 1.2.1

Goatie wrote:

Everything seems to work fine.. except the deleting of multiple messages. As x3dt says it only deletes the first message, not all of them. I hope somebody can find the "bug" and correct it.

has anyone found a fix for this yet?

Offline

 

#29 2005-08-12 05:35:13

Zoltor
Member
From: Minsk, Belarus
Registered: 2005-04-10
Posts: 19
Website

Re: Private Messaging System 1.2.x 1.2.1


Sorry for my english! roll

Offline

 

#30 2005-08-12 11:32:52

propheçy
Member
From: york, pa
Registered: 2005-04-29
Posts: 16
Website

Re: Private Messaging System 1.2.x 1.2.1

awesome, thanks. smile

Offline

 

#31 2005-08-24 16:08:06

freak2532
New member
Registered: 2005-08-24
Posts: 2

Re: Private Messaging System 1.2.x 1.2.1

Just wanted to say thanks for this awesome mod. I just installed it on my punBB 1.2.6 board and everything works perfect. Thanks again...

Offline

 

#32 2005-08-29 07:35:48

Sgt Taliesin
New member
Registered: 2005-08-27
Posts: 3

Re: Private Messaging System 1.2.x 1.2.1

Same as freak2532, it rules !! Good job !

Offline

 

#33 2005-08-29 10:19:17

Keulig
Member
From: France
Registered: 2005-06-29
Posts: 14
Website

Re: Private Messaging System 1.2.x 1.2.1

propheçy wrote:

Goatie wrote:

Everything seems to work fine.. except the deleting of multiple messages. As x3dt says it only deletes the first message, not all of them. I hope somebody can find the "bug" and correct it.

has anyone found a fix for this yet?

Just change (line 66 in my script)

Code:

        // Delete messages 
        $db->query('DELETE FROM '.$db->prefix.'messages WHERE id IN('.intval($_POST['messages']).') AND owner=\''.$pun_user['id'].'\'') or error('Unable to delete messages.', __FILE__, __LINE__, $db->error());

with :

Code:

        // Delete messages 
        $db->query('DELETE FROM '.$db->prefix.'messages WHERE id IN('.$_POST['messages'].') AND owner=\''.$pun_user['id'].'\'') or error('Unable to delete messages.', __FILE__, __LINE__, $db->error());

wink

Offline

 

#34 2005-09-04 13:54:06

owl666
New member
Registered: 2005-08-14
Posts: 3

Re: Private Messaging System 1.2.x 1.2.1

Hi,
i've got two problems after installing the mod ... (using punbb-1.2.7):
1) patch has one failing line (header.php)
2) after doing 'patch -p2 < /path/to/diff' there's debugging enabled... How to disable it, again? (normally via include/common.php - but doesn't work)

BTW, i've an existing DB and still don't know how to upgrade correctly... Normally the 'install_mod.php' must be run, but not, if the DB-entries already exist, or am i wrong?

Greets,
owl

Offline

 

#35 2005-09-15 08:39:44

OdEa
New member
Registered: 2005-09-15
Posts: 4

Re: Private Messaging System 1.2.x 1.2.1

does it works well with 1.2.7???
other peoples had the same problems than owl666?
Thanks!
..should be great to implement it by default in punbb?

Offline

 

#36 2005-09-15 20:28:31

DaveRudd
Guest

Re: Private Messaging System 1.2.x 1.2.1

This is the error that I recieved....

File: /var/www/html/forum/install_mod.php
Line: 61

PunBB reported: Unable to create table messages.

Database reported: Table 'messages' already exists (Errno: 1050)

 

#37 2005-09-16 03:42:22

StevenBullen
Administrator
Registered: 2005-09-13
Posts: 345
Website

Re: Private Messaging System 1.2.x 1.2.1

I would also be interested in anyone has implemeted this mod successfully to 1.2.7. Will keep an eye on the Topic... and have a go myself when I have time.


Blog - Follow Me and FluxBB on Twitter

Offline

 

#38 2005-09-16 12:31:32

OdEa
New member
Registered: 2005-09-15
Posts: 4

Re: Private Messaging System 1.2.x 1.2.1

great I will try to install it so...
thx!

Offline

 

#39 2005-09-17 14:07:47

OdEa
New member
Registered: 2005-09-15
Posts: 4

Re: Private Messaging System 1.2.x 1.2.1

owl666 wrote:

Hi,
i've got two problems after installing the mod ... (using punbb-1.2.7):
1) patch has one failing line (header.php)
2) after doing 'patch -p2 < /path/to/diff' there's debugging enabled... How to disable it, again? (normally via include/common.php - but doesn't work)

BTW, i've an existing DB and still don't know how to upgrade correctly... Normally the 'install_mod.php' must be run, but not, if the DB-entries already exist, or am i wrong?

Greets,
owl

do that:

Code:

//define('PUN_SHOW_QUERIES', 1);

in common.php

I had the same problem, but now all seems to work properly.

Offline

 

#40 2005-09-26 09:07:09

beatle
New member
Registered: 2005-09-26
Posts: 2

Re: Private Messaging System 1.2.x 1.2.1

Some of the members of my board (and I mean some, cause most still can do itm right) get this messages when tryimg to delete multiple messages:

Bad HTTP_REFERER. You were referred to this page from an unauthorized source. If the problem persists please make sure that 'Base URL' is correctly set in Admin/Options and that you are visiting the forum by navigating to that URL. More information regarding the referrer check can be found in the PunBB documentation.

Any suggestions?

Offline

 

#41 2005-09-27 10:21:03

Keulig
Member
From: France
Registered: 2005-06-29
Posts: 14
Website

Re: Private Messaging System 1.2.x 1.2.1

MAJOR SECURITY PROBLEM : Anyone can read other's PMs by simply changing the id after "&quote=" in the adress bar..

To fix this problem, we have to change the mysql request and check if the quoted message is owned by the logged user :
OPEN message_send.php
LINE 67, FIND :

Code:

$result = $db->query('SELECT * FROM '.$db->prefix.'messages WHERE id='.$id) or error('Unable to fetch message info', __FILE__, __LINE__, $db->error());

REPLACE WITH :

Code:

$result = $db->query('SELECT * FROM '.$db->prefix.'messages WHERE id='.$id.' AND owner='.$pun_user['id']) or error('Unable to fetch message info', __FILE__, __LINE__, $db->error());

Last edited by Keulig (2005-09-27 10:29:00)

Offline

 

#42 2005-09-27 13:50:14

arkham
New member
Registered: 2005-09-27
Posts: 4

Re: Private Messaging System 1.2.x 1.2.1

Keulig wrote:

MAJOR SECURITY PROBLEM : Anyone can read other's PMs by simply changing the id after "&quote=" in the adress bar..

To fix this problem, we have to change the mysql request and check if the quoted message is owned by the logged user :
OPEN message_send.php
LINE 67, FIND :

Code:

$result = $db->query('SELECT * FROM '.$db->prefix.'messages WHERE id='.$id) or error('Unable to fetch message info', __FILE__, __LINE__, $db->error());

REPLACE WITH :

Code:

$result = $db->query('SELECT * FROM '.$db->prefix.'messages WHERE id='.$id.' AND owner='.$pun_user['id']) or error('Unable to fetch message info', __FILE__, __LINE__, $db->error());

Very good catch! You should make it clearer that you mean after clicking quote on a PM (although how else would &quote= get in the url). I'm going to patch this up right now.

Offline

 

#43 2005-09-27 13:52:12

arkham
New member
Registered: 2005-09-27
Posts: 4

Re: Private Messaging System 1.2.x 1.2.1

Any plans for adding the ability for users to be notified by email when they receive a PM? Has anyone modded this mod to do that?

Offline

 

#44 2005-09-27 17:44:37

IdleFire
Member
From: Australia
Registered: 2005-06-09
Posts: 44
Website

Re: Private Messaging System 1.2.x 1.2.1

Great catch, Keulig.

Meanwhile, I'll fix it once I've read everyone's pm's tongue

Last edited by IdleFire (2005-09-27 17:45:03)

Offline

 

#45 2005-10-02 02:10:57

Chay
New member
Registered: 2005-10-02
Posts: 2

Re: Private Messaging System 1.2.x 1.2.1

I'm stuck, been trying to get this sorted for ages, but every time i goto install this mod, i get the main installation bit and then i click on install and get this error


An error was encountered
File: C:\apache2triad\htdocs\forum\install_mod.php
Line: 61

PunBB reported: Unable to create table messages.

Database reported: SQL logic error or missing database (Errno: 1)

Offline

 

#46 2005-10-02 03:21:03

b4lz0r
Member
Registered: 2005-10-01
Posts: 28

Re: Private Messaging System 1.2.x 1.2.1

i need it for system 1.2.8
please
it say me i cant mod installed

Offline

 

#47 2005-10-03 03:40:09

Keulig
Member
From: France
Registered: 2005-06-29
Posts: 14
Website

Re: Private Messaging System 1.2.x 1.2.1

b4lz0r wrote:

i need it for system 1.2.8
please
it say me i cant mod installed

1. Open Install_mod.php

2. Find :

Code:

$punbb_versions    = array('1.2.3', '1.2.4', '1.2.5');

3. Replace with :

Code:

$punbb_versions    = array('1.2.8');

Offline

 

#48 2005-10-04 10:12:39

beatle
New member
Registered: 2005-09-26
Posts: 2

Re: Private Messaging System 1.2.x 1.2.1

I have 2 questions regarding the usage of this mod. I have installed it but members are still to attached to the way things worked with phpBB PM system.

Is there any way to know if a sent message has been read by the destiny member?

What happens if you send a message to someone whose inbox is full?

Thanks.

Offline

 

#49 2005-10-04 13:15:18

chucky
New member
Registered: 2005-09-27
Posts: 8

Re: Private Messaging System 1.2.x 1.2.1

are there any bugs with version 1.2.8 ???
thx

Offline

 

#50 2005-10-04 14:11:02

Connorhd
Member
Registered: 2005-01-15
Posts: 202

Re: Private Messaging System 1.2.x 1.2.1

pogenwurst wrote:

http://forums.punbb.org/viewtopic.php?id=6372

If you have trouble, you might refer to this post:
http://forums.punbb.org/viewtopic.php?pid=50955#p50955

Also be aware of this security notice:
http://punres.org/viewtopic.php?id=710

Offline

 

Board footer

Based on PunBB
© Copyright 2002–2005 Rickard Andersson

© Copyright 2004–2006 Kristoffer Jansson

User contributed files are property of their respective owners.