PunBB Resource

_________________________________________________________


PLEASE DO NOT RESPOND TO THIS TOPIC
Mark topics as read has been upgraded to v1.1.3.

_________________________________________________________


Sorry for the very frequent release schedule.  Fortunately there's an easy upgrade from 1.1.0 to 1.1.1:

#
#---------[ 1. OPEN ]---------------------------------------------------------
#

include/functions.php


#
#---------[ 2. FIND (NEAR END OF FILE) ]--------------------------------------
#

function mark_topic_read($topic_id, $forum_id, $last_post) {

    global $db, $pun_user;
    
    if (!empty($pun_user['read_topics']['f'][$forum_id])) {
        $cutoff = $pun_user['read_topics']['f'][$forum_id];
    } else {
        $cutoff = $pun_user['last_visit'];
    }
    
    if ($last_post >= $last_post) {
        $pun_user['read_topics']['t'][$topic_id] = $pun_user['logged'];
        $db->query('UPDATE '.$db->prefix.'users SET read_topics=\''.$db->escape(serialize($pun_user['read_topics'])).'\' WHERE id='.$pun_user['id']) or error('Unable to update read-topic data', __FILE__, __LINE__, $db->error());
    }
}


#
#---------[ 3. REPLACE WITH ]-------------------------------------------------
#

function mark_topic_read($topic_id, $forum_id, $last_post) {

    global $db, $pun_user;
    
    if (topic_is_new($topic_id, $forum_id, $last_post)) {
        $pun_user['read_topics']['t'][$topic_id] = time();
        $db->query('UPDATE '.$db->prefix.'users SET read_topics=\''.$db->escape(serialize($pun_user['read_topics'])).'\' WHERE id='.$pun_user['id']) or error('Unable to update read-topic data', __FILE__, __LINE__, $db->error());
    }
}

#
#---------[ 4. SAVE/UPLOAD ]--------------------------------------------------
#

Last edited by Miles (2005-04-22 19:58:42)

Version 1.1.0 would do an UPDATE everytime a topic was viewed—much of the time, it isn't needed, and would bloat the database.

Version 1.1.1 only does an UPDATE to mark a topic as read if it would otherwise be unread.

It's not a major bug; it doesn't really affect usability at all, just the database and interaction with it.  I'm mostly pushing the releases out right away because for some reason I don't like the thought of people downloading and installing a buggy mod (especially as mods are so hard to install and upgrade), and I'd to get the mod to a complete state as soon as possible.  The only way I can do that is by feedback from others.  :)

That's very odd... my test forum correctly marks threads read after the 1.1.1 update.  If it wouldn't be a security risk, could you uncomment the

// define('PUN_SHOW_QUERIES', 1);

line in your include/common.php, and show me what UPDATE queries are performed, if any, on the users table when you view an unread topic?

Mmkay... I rewrote the 1.1.1 update to use less redundant code, but that probably wouldn't affect your problem.

Last edited by Miles (2005-01-29 17:34:15)

I have the sane problem my punBB doesn't marks topic as read :-(... what to do!? help me some one please

That was a very stupid IF clause on my part (I was tired ;)), but that was in v1.1.0; I fixed it in the 1.1.1 upgrade.  Check the second post in this thread.  Hopefully that will make this mod work for you. :)

Last edited by Miles (2005-02-01 12:59:51)

I've already instaled PunJS Topics.

Sorry to hear that. ;) But in all seriousness, if it works for you, and you like it, that's fine by me.

What I don't like is that my mod doesn't work for you or Widell.  I just installed the mod on a fresh copy of punBB 1.2 according to the directions in readme.txt, and it worked just like I'd expect: topics aren't marked as new anymore after I click them.  You say that it has no effect, that topics are still marked new even after you read them.  If either of you still have it installed somewhere, can you do some testing?  Just log in, go through and read a bunch of new topics, and then check out the contents of the users.read_topics cell for your user?  :)  It might help me figure out what's not working for you guys, and fix it.

Thanks Shindler, cheesypeanut, and Widell for the feedback.  If anyone else has installed this mod, how well is it working (or not working) for you?

I haven't it installed now.. I use the 1.1.0.. I shall install punbb 1.2.1 later then i can try 1.1.1 again. Do you have any im-service? Easier to talk that way if i have problems again..

Will MTaR will work under punBB 1.2.1??

OK so I'm gona try it tommorow (friday)

Thanks a lot for this mod, it should be standard if you ask me.

One request - your directions are easy and clear, but could you please provide a unified diff?  There's no sense in manually updating every file when a simple patch will save us both some trouble :)

Thanks Miles! Now it works fine :)

I'm not familiar with diffs on windows, as they're more oriented for real developers (snicker).  Diffs are just files that thoroughly list the differences between one set of files and another, so that you can easily patch the files and have identical copies.  It's a lot easier to apply than manual changes (like previous versions of this plugin) and it's easier to keep track of exactly what's changed.

Thanks Miles!  (I actually went ahead last night and manually changed everything, I was excited :p)